Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newsfeed unit tests #3430

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Newsfeed unit tests #3430

wants to merge 2 commits into from

Conversation

AartiPhatke
Copy link

Hello,
I noticed that the news feed module did not have any unit test case so created some basic ones.

@rejas
Copy link
Collaborator

rejas commented Apr 27, 2024

Thanks for your work.
But
a) could you please base your PR against the develop branch?
b) could you move the changes to the actual code into another PR?
c) please add a CHANGELOG entry :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AartiPhatke @rejas