Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compliments.js #3444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devilsayshi
Copy link

Hello and thank you for wanting to contribute to the MagicMirror² project

Please make sure that you have followed these 4 rules before submitting your Pull Request:

  1. Base your pull requests against the develop branch.
  2. Include these infos in the description:
  • Does the pull request solve a related issue?
  • If so, can you reference the issue like this Fixes #<issue_number>?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.
  1. Please run npm run lint:prettier before submitting so that
    style issues are fixed.
  2. Don't forget to add an entry about your changes to
    the CHANGELOG.md file.

Note: Sometimes the development moves very fast. It is highly
recommended that you update your branch of develop before creating a
pull request to send us your changes. This makes everyone's lives
easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

@rejas
Copy link
Collaborator

rejas commented May 10, 2024

Hello and thanks for your PR. Please pay attention to the pre-filled text we provide for PRs. Can you be so kind and re-read it and adjust your PR accordingly?

@sdetweil
Copy link
Collaborator

and you can override the list of compliments used, by adding then to your MagicMirror config.js

so the words shown are all up to you, without changing any code

@KristjanESPERANTO
Copy link
Contributor

I can't see the point of this PR. The default texts are okay and the changes are not an improvement in my opinion.

@sdetweil
Copy link
Collaborator

sdetweil commented May 10, 2024

I agree, if the user doesnt want to see the word 'sex', they can add their own compliments strings

wait for user reply, close by end of day June 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants