Make ReadBuffer interface more robust #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st1
approved these changes
Sep 17, 2018
The current ReadBuffer interface is somewhat error prone. There is no way to "peek" at the next message, so various subprotocols that have nested message processing loops have to resort to the `_skip_discard` kludge on the protocol to inform the main loop that it shouldn't skip over to the next message because the subprotocol already read too much. Fix this by adding a way to iterate over the messages without over-reading, and a way to "put" a message back into the buffer when necessary. This also renames `has_message()` to `take_message()` to make it clear that it changes the buffer state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current ReadBuffer interface is somewhat error prone. There is no
way to "peek" at the next message, so various subprotocols that have
nested message processing loops have to resort to the
_skip_discardkludge on the protocol to inform the main loop that it shouldn't skip
over to the next message because the subprotocol already read too much.
Fix this by adding a way to iterate over the messages without
over-reading, and a way to "put" a message back into the buffer when
necessary. This also renames
has_message()totake_message()tomake it clear that it changes the buffer state.