Stop treating ReadyForQuery as a universal result indicator #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
force-pushed
the
proto-refactor
branch
2 times, most recently
from
ca72432
to
e939255
Compare
ReadyForQuery is special in auth and simple query flows, where it _does_ signal the final confirmation of the result, but in all other flows other, more specific messages do that. Now, asyncpg will use the rules of a particular subprotocol when determining the timing of the result waiter wakeup. These changes also make most cases of Sync emission unnecessary, although that cleanup will be addressed in subsequent commits. This consolidation also results in a nice reduction of duplicated code.
elprans
force-pushed
the
proto-refactor
branch
from
e939255
to
7a81613
Compare
1st1
approved these changes
Sep 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadyForQuery is special in auth and simple query flows, where it does
signal the final confirmation of the result, but in all other flows
other, more specific messages do that. Now, asyncpg will use the
rules of a particular subprotocol when determining the timing of the
result waiter wakeup. These changes also make most cases of Sync
emission unnecessary, although that cleanup will be addressed in
subsequent commits. This consolidation also results in a nice
reduction of duplicated code.