Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide wheel for python3.9 #59

Closed
dvzrv opened this issue Dec 4, 2020 · 9 comments
Closed

provide wheel for python3.9 #59

dvzrv opened this issue Dec 4, 2020 · 9 comments

Comments

@dvzrv
Copy link

dvzrv commented Dec 4, 2020

Would it be possible to add wheels for python3.9 with a new patch release? :)
Currently it is only possible to compile the package on the fly in a virtualized environment on python3.9.

@asfaltboy
Copy link

@fantix @elprans could/should we port the Github Actions CI build script from MagicStack/uvloop into httptools to support 3.9? Or maybe even use joerick/cibuildwheel Or is there another requirement to support 3.9?

@b0g3r
Copy link
Contributor

b0g3r commented Mar 20, 2021

It would be very useful to have wheels for httptools on 3.9. A big part of python's async framework ecosystems (e.g. uvicorn, popular asgi server) depends on httptools. It means, that for installing uvicorn[standard] to docker3.9 we need not only python, but also python-dev for building. It's increases the build-time and weight of a resulting image.

I could be wrong, but it looks like all it needed is append 3.9 to the build and test matrix.

@cmacht
Copy link

cmacht commented Apr 9, 2021

I'm trying to install uvicorn for fastapi on shared hosting where I cannot fix the missing dependency myself. So very much looking forward to seeing the accepted PR in a release soon.

@pauloxnet
Copy link

Thanks for your work on this package.

Can you please release a wheel for Python 3.9 ?

@pauloxnet
Copy link

@fantix thanks for the 0.2.0 release.

Unfortunately the original request of this issue was a wheel package for the 0.1.1 version of httptools for python 3.9 because, as @b0g3r wrote above, uvicorn[standard] require httptools==0.1.*

After the 0.2.0 release nothing has changed for people that are using uvicorn with python3.9.

Can you please add a python3.9 compatible wheel for httptools==0.1.1 ?

Thanks in advance for your work here 🙏

@fantix
Copy link
Member

fantix commented Apr 26, 2021

@pauloxnet oh sure thing! I think I could backport the 3.9 fix together with 9340d32, and release 0.1.2. Sounds like a plan?

@fantix
Copy link
Member

fantix commented Apr 26, 2021

Fixed in #66, please feel free to let me know if there're more issues.

@fantix fantix closed this as completed Apr 26, 2021
@pauloxnet
Copy link

Yes, thanks it worked.

@cmacht
Copy link

cmacht commented Apr 26, 2021

Works here as well. Wonderful! Thanks for acting so fast! 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants