Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and build Python 3.12, drop Python 3.7 support #95

Merged
merged 1 commit into from Oct 16, 2023
Merged

Test and build Python 3.12, drop Python 3.7 support #95

merged 1 commit into from Oct 16, 2023

Conversation

tiptenbrink
Copy link
Contributor

@tiptenbrink tiptenbrink commented Oct 16, 2023

#94 asks for wheels to be built for Python 3.12. This simply updates the CI and bumps the version to 0.6.1 so a new release can be made that includes the new Python 3.12 wheels. All tests are passing.

Probably it would be a good idea to drop Python 3.5 to 3.7 support, so if desirable I could update that as well. There's also some old actions being used, I can also bump those.

@tiptenbrink
Copy link
Contributor Author

Pinging @fantix. Also thanks for updating other packages already (i.e. uvloop), I know it can be quite a lot of work, but here it seems manageable so that's why I'm contributing this.

@fantix
Copy link
Member

fantix commented Oct 16, 2023

Thanks for the PR! We usually bump the version in a separate PR/commit with changelogs (for the release bot to do its job), so let's keep this PR bumping Python versions and stuff.

Let's also fix the following to match our minimum requirement (Python 3.8):

if vi < (3, 5):

python_requires='>=3.5.0',

@tiptenbrink tiptenbrink changed the title 0.6.1 to build Python 3.12 Test and build Python 3.12, drop Python 3.7 support Oct 16, 2023
@tiptenbrink
Copy link
Contributor Author

Alright, should be fixed now!

@fantix fantix merged commit 25f412b into MagicStack:master Oct 16, 2023
15 checks passed
fantix added a commit that referenced this pull request Oct 16, 2023
Changes
=======

* Explicit Python 3.12 support and build wheels, change min version to 3.8 (#95)
  (by @tiptenbrink in 25f412b for #95)

* Do not install the *.c sources in wheels (#73)
  (by @hroncok in b2fc5bd for #73)
@fantix fantix mentioned this pull request Oct 16, 2023
fantix added a commit that referenced this pull request Oct 16, 2023
Changes
=======

* Explicit Python 3.12 support and build wheels, change min version to 3.8 (#95)
  (by @tiptenbrink in 25f412b for #95)

* Do not install the *.c sources in wheels (#73)
  (by @hroncok in b2fc5bd for #73)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants