Add __contains__ to MapKeys #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into this when I tried to pass `.keys()` to something declared to take a `Collection`, and it failed because it lacked `__contains__`. (I didn't actually care about `__contains__`, but mypy did.) So I came to add it to the stubs and discovered that it *was* actually missing, and since the fallback is woefully slow I went and implemented it.
elprans
approved these changes
Jul 21, 2023
elprans
added a commit
that referenced
this pull request
Aug 14, 2023
Changes ======= * Enable support for pattern matching (#96) (by @antonagestam in 7071a24 for #96) * add support for aix/sunos (#98) (by @mattp- in 765e4ee for #98) * Python 3.12 compatibility (#105) (by @elprans in f797822 for #105) * Add __contains__ to MapKeys (#99) (by @msullivan in 6790111 for #99) * Add PEP 585 GenericAlias support (#101) (by @eltoder in 9ce64c5 for #101) * Move metadata to `pyproject.toml`, fix test fixture inclusion in sdist (#111) (by @elprans in ea65656 for #111)
elprans
added a commit
that referenced
this pull request
Aug 14, 2023
Changes ======= * Enable support for pattern matching (#96) (by @antonagestam in 7071a24 for #96) * add support for aix/sunos (#98) (by @mattp- in 765e4ee for #98) * Python 3.12 compatibility (#105) (by @elprans in f797822 for #105) * Add __contains__ to MapKeys (#99) (by @msullivan in 6790111 for #99) * Add PEP 585 GenericAlias support (#101) (by @eltoder in 9ce64c5 for #101) * Move metadata to `pyproject.toml`, fix test fixture inclusion in sdist (#111) (by @elprans in ea65656 for #111)
Merged
elprans
added a commit
that referenced
this pull request
Aug 14, 2023
Changes ======= * Enable support for pattern matching (#96) (by @antonagestam in 7071a24 for #96) * add support for aix/sunos (#98) (by @mattp- in 765e4ee for #98) * Python 3.12 compatibility (#105) (by @elprans in f797822 for #105) * Add __contains__ to MapKeys (#99) (by @msullivan in 6790111 for #99) * Add PEP 585 GenericAlias support (#101) (by @eltoder in 9ce64c5 for #101) * Move metadata to `pyproject.toml`, fix test fixture inclusion in sdist (#111) (by @elprans in ea65656 for #111)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this when I tried to pass
.keys()to something declaredto take a
Collection, and it failed because it lacked__contains__. (I didn't actually care about__contains__, but mypydid.)
So I came to add it to the stubs and discovered that it was actually
missing, and since the fallback is woefully slow I went and
implemented it.