Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py for setuptools 69 #13

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Conversation

aljazerzen
Copy link
Contributor

Move fields from setup.py into pyproject.toml.

This is required because setuptools version 69 is reporting the following error:

➜  parsing git:(main) ✗ pip install .
Processing /home/aljaz/EdgeDB/parsing
  Installing build dependencies ... done
  Getting requirements to build wheel ... error
  error: subprocess-exited-with-error
  
  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [57 lines of output]
      /tmp/pip-build-env-l5q640ua/overlay/lib/python3.11/site-packages/setuptools/config/_apply_pyprojecttoml.py:75: _MissingDynamic: `optional-dependencies` defined outside of `pyproject.toml` is ignored.
      !!
      
              ********************************************************************************
              The following seems to be defined outside of `pyproject.toml`:
      
              `optional-dependencies = {'test': ['flake8', 'mypy>=1.4.1']}`
      
              According to the spec (see the link below), however, setuptools CANNOT
              consider this value unless `optional-dependencies` is listed as `dynamic`.
      
              https://packaging.python.org/en/latest/specifications/declaring-project-metadata/
      
              To prevent this problem, you can list `optional-dependencies` under `dynamic` or alternatively
              remove the `[project]` table from your file and rely entirely on other means of
              configuration.
              ********************************************************************************
      
      !!

msullivan
msullivan previously approved these changes Nov 24, 2023
msullivan
msullivan previously approved these changes Nov 24, 2023
fantix
fantix previously approved these changes Nov 24, 2023
setup.py Outdated Show resolved Hide resolved
@aljazerzen aljazerzen dismissed stale reviews from fantix and msullivan via df8d08a November 24, 2023 17:53
@fantix fantix merged commit bfdf958 into MagicStack:main Nov 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants