Fix unpickling when compiled with newer mypycs #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mypyc breaks pickling by default now (https://mypyc.readthedocs.io/en/latest/differences_from_python.html#pickling-and-copying-objects), and we need to opt out. Somewhat surprisingly, that seems to be insufficient. When allow_interpreted_subclasses isn't set, many of the objects will be allegedly unpickled but none of their attributes are set. This /seems/ like a mypyc bug, but I haven't looked into it yet.
elprans
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypyc breaks pickling by default now
(https://mypyc.readthedocs.io/en/latest/differences_from_python.html#pickling-and-copying-objects),
and we need to opt out.
Somewhat surprisingly, that seems to be insufficient. When
allow_interpreted_subclasses isn't set, many of the objects will be
allegedly unpickled but none of their attributes are set. This /seems/
like a mypyc bug, but I haven't looked into it yet.