Fix uvloop to run on 3.8 #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 3.8 a lot of asyncio functions have their `loop` parameter deprecated. So we change the semantics of uvloop tests to never pass the loop explicitly (unless to Future objects, when necessary) That means that we now also need to set up asyncio/uvloop loop policies for tests in setUp hooks.
elprans
reviewed
Oct 24, 2019
Jamim
suggested changes
Oct 24, 2019
1st1
force-pushed
the
3.8
branch
2 times, most recently
from
0c2cb54
to
2e131bd
Compare
drewrisinger
added a commit
to drewrisinger/nixpkgs
that referenced
this pull request
Apr 4, 2020
Allow build pass by disabling test. Isolated issue to test_sockets.py::TestAIOSockets::test_sock_close_add_reader_race. This test is supposed to be skipped, but it isn't for some reason, so we disable it instead. See uvloop#284 (MagicStack/uvloop#284) for full details. Don't know why this test isn't properly skipped.
10 tasks
drewrisinger
added a commit
to drewrisinger/nixpkgs
that referenced
this pull request
Apr 4, 2020
Allow build pass by disabling test. Isolated issue to test_sockets.py::TestAIOSockets::test_sock_close_add_reader_race. This test is supposed to be skipped, but it isn't for some reason, so we disable it instead. See uvloop#284 (MagicStack/uvloop#284) for full details. Don't know why this test isn't properly skipped. (cherry picked from commit 364909d)
stigok
pushed a commit
to stigok/nixpkgs
that referenced
this pull request
Jun 12, 2020
Allow build pass by disabling test. Isolated issue to test_sockets.py::TestAIOSockets::test_sock_close_add_reader_race. This test is supposed to be skipped, but it isn't for some reason, so we disable it instead. See uvloop#284 (MagicStack/uvloop#284) for full details. Don't know why this test isn't properly skipped. (cherry picked from commit 364909d)
andrew-motesque
added a commit
to Motesque/vagrant-development-box
that referenced
this pull request
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses: #277 and #266.