Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rgbpp dashboard #285

Merged
merged 31 commits into from
Apr 19, 2024
Merged

Feature/rgbpp dashboard #285

merged 31 commits into from
Apr 19, 2024

Conversation

Daryl-L
Copy link

@Daryl-L Daryl-L commented Apr 8, 2024

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 9:47am

src/components/FilterButton/index.tsx Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
src/locales/zh.json Outdated Show resolved Hide resolved
src/services/ExplorerService/fetcher.ts Outdated Show resolved Hide resolved
src/pages/StatisticsChart/common/index.tsx Outdated Show resolved Hide resolved
src/pages/RGBPP/TransactionList/index.tsx Outdated Show resolved Hide resolved
src/pages/RGBPP/TransactionList/index.tsx Outdated Show resolved Hide resolved
src/pages/RGBPP/TransactionList/List/index.tsx Outdated Show resolved Hide resolved
src/pages/RGBPP/TransactionList/List/index.tsx Outdated Show resolved Hide resolved
@Keith-CY
Copy link
Member

Keith-CY commented Apr 9, 2024

Maybe the RGB++ entry should be added in the navigation

@Keith-CY
Copy link
Member

Keith-CY commented Apr 9, 2024

Preview is available at https://ckb-explorer-frontend-in-magickbase-repo-git-217d3f-magickbase.vercel.app/en/rgbpp/transaction/list cc @FrederLu

@FrederLu
Copy link

Preview is available at https://ckb-explorer-frontend-in-magickbase-repo-git-217d3f-magickbase.vercel.app/en/rgbpp/transaction/list cc @FrederLu

UI
image
image

image image

1、The left spacing of the RGB++ Transaction List font in the upper left corner is too small, the font color is wrong, and the font px is too small. Pay attention to the adaptation on the mobile terminal.
2、The height of the chart is too large, you can refer to the height of the linked chart(https://pudge.explorer.nervos.org/charts/average-block-time).


UI
image

image image

3、The list of discovery pages appears shifted to the right.


image image 4、When the page is switched to Chinese, the title lacks Chinese information.

https://pudge.explorer.nervos.org/en/block/list
image

image

5、The font in the screenshot is thicker, you can refer to the existing list font style.


image image

6、The data names displayed on the left and right sides of the chart are inconsistent with those on prd. At the same time, the chart used by the data lacks a histogram.

@Sven-TBD
Copy link

  "transaction_num": "Transaction Count 交易数量",
  "new_btc_address": "New BTC Address 新BTC地址",
  "rgbpp_transaction_list": "RGB++ Transaction List RGB++ 交易列表",

@FrederLu
Copy link

FrederLu commented Apr 10, 2024

image image
2024-04-10.11.41.19.mov

7、When clicking on BTC TXID, the information jumps abnormally and the external jump icon is missing.


2024-04-10.11.46.41.mov

8、The ordering between Block Number, Confirmation and Time is independently unrelated. Now it is found that Block Number and Confirmation are related.
At the same time, switching back and forth between sorting will cause ascending/reverse order data confusion.


image

https://ckb-explorer-frontend-in-magickbase-repo-git-217d3f-magickbase.vercel.app/en/transaction/0x638c01595d41dd6ce44a70a7aa457fea3994d3c744b4f89bfdba2f66abff0224
image

image

https://ckb-explorer-frontend-in-magickbase-repo-git-217d3f-magickbase.vercel.app/en/transaction/0x8339a39c577e240e21168cee4272c2a67e30c91889c91b5d5ddb66f37c739d2d
image

image

https://ckb-explorer-frontend-in-magickbase-repo-git-217d3f-magickbase.vercel.app/en/transaction/0xb5ab95c023e6849d676da6e68cff19e744637ae333736235695fe923590312ba
image
9、The Type information on the list does not match the information in the transaction details.


image

https://ckb-explorer-frontend-in-magickbase-repo-git-217d3f-magickbase.vercel.app/en/transaction/0x7ac318fda2d0b6bf87b7f05b14908c2ea1bac41c97058cbaa29853ae686202de
image
10、For this kind of data, you only need to look at the RGB cells. If the input/output difference in the transaction details is 5, then -5 cells should be displayed.


image image

11、If there is no data, we can use / to display it and not display the blank /-.


image image

12、If the cell is added, the + symbol is required.

@FrederLu
Copy link

image
2024-04-10.14.43.38.mov

@Sven-TBD
Confirmation will theoretically continue to increase. Is there a need for an upper limit style? Similar screenshot
image

Likewise, the Time style currently sees a maximum value of 16 days. Whether to use the screenshot style if the style is older than 1 day.
image

@rabbitz
Copy link

rabbitz commented Apr 10, 2024

10、For this kind of data, you only need to look at the RGB cells. If the input/output difference in the transaction details is 5, then -5 cells should be displayed.

nervosnetwork/ckb-explorer#1770

@rabbitz
Copy link

rabbitz commented Apr 10, 2024

9、The Type information on the list does not match the information in the transaction details.

nervosnetwork/ckb-explorer#1774

@Daryl-L
Copy link
Author

Daryl-L commented Apr 11, 2024

Maybe the RGB++ entry should be added in the navigation

added

@FrederLu
Copy link

FrederLu commented Apr 15, 2024

  "transaction_num": "Transaction Count 交易数量",
  "new_btc_address": "New BTC Address 新BTC地址",
  "rgbpp_transaction_list": "RGB++ Transaction List RGB++ 交易列表",
image

Display according to the Chinese information given by PM.


image

The problem still exists.


image image

It should not be appropriate to display decimals for coordinates and single points. The interface returns all integers.


image

Clicking on the BTC TXID information (address/icon) should jump to external BTC browsing, but clicking on the address to jump is still abnormal.


image image

The bottom of the chart looks weird on mobile.

@Keith-CY
Copy link
Member

The border should be rounded

image image

@FrederLu
Copy link

The border should be rounded

image image

image image

The upper/lower corners on the right side of the chart are not processed.

@Keith-CY Keith-CY added this pull request to the merge queue Apr 19, 2024
Merged via the queue into develop with commit c6dfaef Apr 19, 2024
8 checks passed
@Keith-CY Keith-CY deleted the feature/rgbpp-dashboard branch April 19, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants