Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(live-cell): jump when click the live cell #303

Closed
wants to merge 4 commits into from

Conversation

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 3:15am

src/pages/Address/Cells.tsx Outdated Show resolved Hide resolved
src/pages/Address/Cells.tsx Outdated Show resolved Hide resolved
@Keith-CY
Copy link
Member

Conflicted

@Daryl-L
Copy link
Author

Daryl-L commented May 30, 2024

Conflicted

I found that this feature might be added in develop branch after recent merging

@Keith-CY
Copy link
Member

Conflicted

I found that this feature might be added in develop branch after recent merging

Wow.. so we can close this PR if all updates have been done in the develop branch? Or we can remove some in this PR and update the rest.

@Daryl-L
Copy link
Author

Daryl-L commented May 30, 2024

Conflicted

I found that this feature might be added in develop branch after recent merging

Wow.. so we can close this PR if all updates have been done in the develop branch? Or we can remove some in this PR and update the rest.

Link to xUDT page is not in develop, as it is easy to copy the codes other than resolve the conflict, so I will launch another PR for this feature.

@FrederLu
Copy link

FrederLu commented May 30, 2024

image

1、The pop-up window cannot be closed by clicking X.


2024-05-30.14.24.57.mov

2、The cell info pop-up window should not be displayed when jumping to the transaction details page.


Inscriptions:https://ckb-explorer-frontend-in-magickbase-repo-9b1td77nw-magickbase.vercel.app/zh/address/ckt1qpyn2yx4f6q4vydxgwhe0ddvjwlmk3wac24wpukuala0xsytfl8u6q2tqqqqqyqqqqqrqqqqqqcsqqqq7v57llgugadzj7z98jrqpc027z7zpplwpy7raejve9hvdprh2t9sz9sqqqqqg5u8yd5gkehe87edwwend849auln2ls2cqqqqqqqqqqqqqqqqqqqqqpvkstcqqwfctl8
image
image

sUDT: https://ckb-explorer-frontend-in-magickbase-repo-9b1td77nw-magickbase.vercel.app/en/address/ckt1qq6pngwqn6e9vlm92th84rk0l4jp2h8lurchjmnwv8kq3rt5psf4vqvu7gslx9z2he2slvsymdfhgpw7tl4yhtcsp984x

DOB:https://ckb-explorer-frontend-in-magickbase-repo-9b1td77nw-magickbase.vercel.app/address/ckt1qrfrwcdnvssswdwpn3s9v8fp87emat306ctjwsm3nmlkjg8qyza2cqgqqx0ppa3gs9leysm9ertq95t2q00cljcndut62vc3
https://ckb-explorer-frontend-in-magickbase-repo-9b1td77nw-magickbase.vercel.app/address/ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsqf5kmkgn25z8xajscwkw88ew3hagjfd5uqttnscm

m-NFT:https://ckb-explorer-frontend-in-magickbase-repo-9b1td77nw-magickbase.vercel.app/address/ckt1qrfrwcdnvssswdwpn3s9v8fp87emat306ctjwsm3nmlkjg8qyza2cqgqq85apn2vnk482lxg8p3uk30r78srnc0aqvyssuun

NRC 721:https://ckb-explorer-frontend-in-magickbase-repo-9b1td77nw-magickbase.vercel.app/en/address/ckt1qpvvtay34wndv9nckl8hah6fzzcltcqwcrx79apwp2a5lkd07fdxxq0ecfzek8k40fkpgxfpm3d5qmcntnqvrpqjr90cd

3、There is no jump when clicking the xudt name. At the same time, when there are assets (sUDT/DOB/m-NFT/NRC 721/Inscriptions) displayed in the Live cell, click to jump to the corresponding asset list page.

@Keith-CY
Copy link
Member

Conflicted

I found that this feature might be added in develop branch after recent merging

Wow.. so we can close this PR if all updates have been done in the develop branch? Or we can remove some in this PR and update the rest.

Link to xUDT page is not in develop, as it is easy to copy the codes other than resolve the conflict, so I will launch another PR for this feature.

Got it, please close this one when the new one is open

@Daryl-L Daryl-L closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants