Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 'error' event to allow users handle errors #345

Merged
merged 1 commit into from
Oct 7, 2020
Merged

add 'error' event to allow users handle errors #345

merged 1 commit into from
Oct 7, 2020

Conversation

jmikerq
Copy link
Contributor

@jmikerq jmikerq commented Jul 30, 2020

Instead of throwing the error, add error event to allow users to handle the error with customize actions.

@jmikerq
add 'error' event to allow users handle errors
cf8e78c 
Instead of throwing the error, add error event to allow users to handle the error with customize actions.
zergioz
zergioz requested changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@zergioz zergioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved merger for error handling function: _processSuggestions

@zergioz zergioz self-requested a review October 7, 2020 05:21
@zergioz zergioz merged commit 668b7b6 into Magicsuggest:master Oct 7, 2020
zergioz
zergioz reviewed Oct 7, 2020
View reviewed changes
Copy link
Contributor

@zergioz zergioz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved merger for error handling function _processSuggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zergioz zergioz zergioz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmikerq @zergioz