Fix setting file permissions in post-fs-data.sh #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My certificate got added with permissions 660, because the original file had those permissions. I assume set_perm_recursive didn't work at all and the owner got changed to root because of the cp. Either way, if the cert files in cacerts-custom end up with the default android file permissions 660, the certs don't work because nothing can read them. I tried the second line, which is copied straight from the Fdroid-Priv extension, because those perms got set correctly on my device, but that didn't work here either. I assume set_perm_recursive isn't available in post-fs-data scripts, only in install.sh. chmod and chown work fine for me (Android 11 Magisk 24.1)
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My certificate got added with permissions 660, because the original file had those permissions. I assume set_perm_recursive didn't work at all and the owner got changed to root because of the cp. Either way, if the cert files in cacerts-custom end up with the default android file permissions 660, the certs don't work because nothing can read them.
I tried the second line, which is copied straight from the Fdroid-Priv extension, because those perms got set correctly on my device, but that didn't work here either.
I assume set_perm_recursive isn't available in post-fs-data scripts, only in install.sh.
chmod and chown work fine for me (Android 11 Magisk 24.1)