-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various improvements to config code #102
base: main
Are you sure you want to change the base?
Conversation
Add doc comments Make generate_config() private
We were actually thinking of moving away from RON to a more user-friendly custom config, this might be an opportunity |
Oh awesome, I was gonna ask if I could do that. I was thinking TOML, is that what you had in mind? |
I'm also considering storing the default config as TOML or whatever we go with so that we don't have to write out the default config in rust, serialize it, then immediately de-serialize it the way we're doing now. |
As per our discord discussion, TOML is off the table for this PR. |
I hope we don't pick yaml :p |
When I say TOML is off the table I mean this PR is done, I am not implementing a config language change at this time. |
generate_config()
private