Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Floating #44

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add Floating #44

wants to merge 7 commits into from

Conversation

HackedOS
Copy link
Member

@HackedOS HackedOS commented May 21, 2023

  • Reliable Detection
  • Move and Resize grabs
  • Hotkey to switch between floating and tiling

@mfdorst
Copy link
Contributor

mfdorst commented Apr 23, 2024

Resolves #108

@HackedOS
Copy link
Member Author

OH WTF THIS IS NOT MERGED???? LMAO
i have been using floating all this time on a private build 🤣

@eepy-goddess
Copy link
Member

The silly

@mfdorst
Copy link
Contributor

mfdorst commented Apr 23, 2024

I guess cause electron hasn't reviewed it. I'll take a look.

@mfdorst mfdorst self-requested a review April 23, 2024 20:38
@electron271
Copy link
Contributor

it was a draft and a review was never requested

@mfdorst
Copy link
Contributor

mfdorst commented Apr 23, 2024

Can you merge with main? I can't test it without a flake.

@mfdorst
Copy link
Contributor

mfdorst commented Apr 23, 2024

it was a draft and a review was never requested

Oh gotcha. I only said that cause it said something about a pending review from you. Idk how github works lol

@salahoued
Copy link

Sorry It may sound silly, but is MagmaWM a tiling only Compositor (WM)? and by Floating windows you don't mean stacking, but a feature to get some windows out of tiling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

6 participants