-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export krr
, fix tests
#7
Conversation
In cases where the error in v1.7 was similar, I just replaced with with the new error. |
…e StableRNGs.jl for tests.
…x PERK to magnitude-only PERK.
I had wanted to incorporate StableRNGs.jl into the tests, so thanks for making a PR to motivate me to do that :) I'll just merge this PR after CI finishes. |
Hmm, tests pass locally but not in CI... |
Having to put The values I put in there are for julia 1.7 so I don't know if they work with 1.6. |
I agree; I should have clarified: when I added StableRNGs, I also changes all the comparison values (overwriting the changes you made). So the tests pass locally for me for both v1.6.5 and v1.7.1, so I'm not sure why they fail on CI. |
I'm just going to merge this and then try to figure out the CI issues separately. |
and more use of
using
to help reader (e.g., me) know what is used where.