Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MahApps.Metro consistent style and template names/keys #2384

Closed
punker76 opened this issue Mar 1, 2016 · 6 comments · Fixed by #3552, #3557 or #3560
Closed

MahApps.Metro consistent style and template names/keys #2384

punker76 opened this issue Mar 1, 2016 · 6 comments · Fixed by #3552, #3557 or #3560
Assignees
Milestone

Comments

@punker76
Copy link
Member

punker76 commented Mar 1, 2016

MahApps.Metro styles and template keys are non consostent.

Expected outcome

Consistent names/keys for all styles and templates.

e.g.

Win10WindowButtonCommandsTemplate -> MahApps.Metro.Templates.WindowButtonCommands.Win10
MetroFlatButton -> MahApps.Metro.Styles.FlatButton

etc

@punker76 punker76 self-assigned this Mar 1, 2016
@punker76 punker76 added this to the 2.0.0 milestone Mar 1, 2016
@amkuchta
Copy link
Contributor

amkuchta commented Sep 8, 2017

This is going to be so tedious 😶 😶

@punker76
Copy link
Member Author

punker76 commented Sep 8, 2017

@amkuchta v2.0 will be a great release -:-D

@Evangelink
Copy link
Contributor

Hi @punker76,

Is this ticket still active? If so, which naming do you want to go for?

I'd be happy to give some help.

@Evangelink
Copy link
Contributor

@punker76 what do you think about the following convention:

MahApps.Metro.
+ Style. or Template.
+ Category (e.g. Metro, Flat, Square, Win10...)
+ Control (e.g. Button, ToggleButton...)
+ optional specifier (e.g. Light, Dark, Accented...)

which would give the following names:

  • MahApps.Metro.Style.Flat.Button
  • MahApps.Metro.Style.Metro.Button
  • MahApps.Metro.Style.Metro.WindowButton.Base
  • MahApps.Metro.Style.Metro.WindowButton.Light
  • MahApps.Metro.Style.Metro.TextBox.Search
  • MahApps.Metro.Style.Metro.TextBox.Button

Remarks:

  • We could omit the Metro after Style./Template. to avoid the redundancy but it would be less of a standard construction

  • We could omit the Metro after MahApps. but I don't know from a product name POV if that's ok.

  • We could merge the Control and specifier parts to get something like SearchTextBox, ButtonTextBox, LightWindowButton, DarkWindowButton...

WDYT?

@punker76
Copy link
Member Author

@Evangelink You are going in the same direction as I want to go:

I already changed some of the styles with these naming, like

  • MahApps.Metro.Styles.xyz
  • MahApps.Metro.Styles.DataGrid.xyz ... xyz.Win10
  • MahApps.Metro.Styles.Slider.xyz ... xyz.Win10
  • MahApps.Metro.Styles.FlatSlider.xyz ...

and

  • MahApps.Metro.Templates.WindowButtonCommands.xyz
  • MahApps.Metro.Templates.MetroTabControl.xyz

and so on.

So my convention was

MahApps.Metro

  • Styles or Templates or Brushes
  • Control (e.g. DataGrid, Slider, ...)
  • Optional Specifier
  • Catagory (e.g. Win10)

And yes, I'm also with these

  • omit Metro after MahApps, because we are more and more MahApps ;-D (because of teh Win10 styles)
  • merge Control and specifier parts

@Evangelink
Copy link
Contributor

Evangelink commented Jul 18, 2019

Final naming convention chosen is:

MahApp.
+ the resource type which is one of Colors., Brushes., Templates., Sizes., Fonts., Storyboard., Styles.
+ the target control for Templates and Styles (e.g. Slider., Window....)
+ an optional specifier which gives more context (e.g. Slider for MahApps.Styles.Thumb which helps understanding that this thumb style is for the context of a slider)
+ an optional category (e.g. Metro, Flat, Square, Win10...)

punker76 added a commit that referenced this issue Jul 20, 2019
punker76 added a commit that referenced this issue Jul 22, 2019
(GH-2384) Subsequent changes after #3552 Update resource names
punker76 added a commit that referenced this issue Jul 23, 2019
(GH-2384) Subsequent change after #3552 Update colors names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment