New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent FloatingWatermark Alignment #2627

Closed
AndrzejKl opened this Issue Aug 28, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@AndrzejKl

AndrzejKl commented Aug 28, 2016

What steps will reproduce this issue?

Just add TextBox, DatePicker and NumericUpDown to MetroWindow and activate Floating Watermarks
Write problem description here
For TextBox Alignment is Left;
For DatePicker is Center;
For NumericUpDown is Right;

image
image

Expected outcome

Should be the same or should be possible to change it, like:
Controls:TextBoxHelper.FloatingWatermarkAlignment="Left, Center, Right"

EDIT:
I found way to align it - it reacts for HorizontalContentAlignment, but DatePicker and TextBox Text also reacts on it. Only it works correctly with NumericUpDown control. It have own property TextAlignment, so I can separately align Text and Watermark.

Environment

  • MahApps.Metro v1.3.0.ALPHA 190
  • Windows 10
  • Visual Studio 2015
  • .NET Framework 4.5
@xxMUROxx

This comment has been minimized.

Show comment
Hide comment
@xxMUROxx

xxMUROxx Sep 6, 2016

Contributor

I will look into that issue

Contributor

xxMUROxx commented Sep 6, 2016

I will look into that issue

@xxMUROxx

This comment has been minimized.

Show comment
Hide comment
@xxMUROxx

xxMUROxx Sep 6, 2016

Contributor

I checked the issue with the newest sources and the floating watermarks are always aligned to the value set to HorizontalContentAlignment. Is NumericUpDown this value is set by default to Right

Contributor

xxMUROxx commented Sep 6, 2016

I checked the issue with the newest sources and the floating watermarks are always aligned to the value set to HorizontalContentAlignment. Is NumericUpDown this value is set by default to Right

@AndrzejKl

This comment has been minimized.

Show comment
Hide comment
@AndrzejKl

AndrzejKl Sep 6, 2016

@xxMUROxx that's right, see my Edit.
But, don't you think that's better to decide how should be align watermark? In my opinion on DatePicker from my first post Watermark will look better left aligned, but when I set HorizontalContentAlignment to Left, also DatePicker Text will be left Aligned, but Text looks better on center...
It shouldn't be a big problem to Add new feature like in my first post "Expected outcome"...

AndrzejKl commented Sep 6, 2016

@xxMUROxx that's right, see my Edit.
But, don't you think that's better to decide how should be align watermark? In my opinion on DatePicker from my first post Watermark will look better left aligned, but when I set HorizontalContentAlignment to Left, also DatePicker Text will be left Aligned, but Text looks better on center...
It shouldn't be a big problem to Add new feature like in my first post "Expected outcome"...

@xxMUROxx

This comment has been minimized.

Show comment
Hide comment
@xxMUROxx

xxMUROxx Sep 13, 2016

Contributor

@punker76 what do you think?

Contributor

xxMUROxx commented Sep 13, 2016

@punker76 what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment