Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animated Single Row Tab Control arrow icon is incorrect when setting flow direction right to left #3660

Closed
VahidHajizadeh opened this issue Oct 25, 2019 · 3 comments
Closed

Animated Single Row Tab Control arrow icon is incorrect when setting flow direction right to left #3660

VahidHajizadeh opened this issue Oct 25, 2019 · 3 comments
Assignees
@punker76
Labels
Bug
Milestone
2.0.0

Comments

@VahidHajizadeh
Copy link

VahidHajizadeh commented Oct 25, 2019 •
edited by punker76

Hello, when I use Tab Control in a Right-to-left window, the arrow's icon keeps its direction like Left-to-right mode. It's should change.

<Grid>
    <Grid.Resources>
        <ResourceDictionary Source="pack://application:,,,/MahApps.Metro;component/Styles/Controls.AnimatedSingleRowTabControl.xaml"/>
    </Grid.Resources>

    <TabControl mah:TabControlHelper.IsUnderlined="True"
                mah:TabControlHelper.Underlined="TabPanel"
                x:Name="MainTab"
                controlzex:KeyboardNavigationEx.AlwaysShowFocusVisual="True"
                Loaded="MainTab_Loaded">
        <mah:MetroTabItem Header="لیست دانش آموزان" CloseButtonEnabled="True"  CloseButtonMargin="10,15,10,0"/>
    </TabControl>
</Grid>

Screenshot:

Untitled

How to solve this? Please Guide me.
@VahidHajizadeh
Copy link
Author

when I changed flow diretction at runtime, problem solved temporarily

screenshots:
1:
1

2:
2

3:
3

@punker76 punker76 added the Bug label Nov 3, 2019
@punker76 punker76 added this to the 2.0.0 milestone Nov 3, 2019
@punker76 punker76 self-assigned this Nov 3, 2019
punker76 added a commit that referenced this issue Nov 3, 2019
@punker76
(GH-3660) Fix incorrect icon flow direction in AnimatedSingleRowTabCo…
0e745d2 
…ntrol style when setting flow direction RightToLeft

The flow direction is set to LeftToRight through the MahApps.Styles.ContentControl.PathIcon style. So we must override it at this template.

Closes ##3660
@punker76
Copy link
Member

punker76 commented Nov 3, 2019

@VahidHajizadeh this has now been fixed, and it will be released in the next version of MahApps.Metro v2.0

@VahidHajizadeh
Copy link
Author

thanks a lot for your fix and lovely mahapps

amkuchta pushed a commit to amkuchta/MahApps.Metro that referenced this issue Nov 19, 2019
@punker76 @amkuchta
(MahAppsGH-3660) Fix incorrect icon flow direction in AnimatedSingleR…
de7d6b5 
…owTabControl style when setting flow direction RightToLeft

The flow direction is set to LeftToRight through the MahApps.Styles.ContentControl.PathIcon style. So we must override it at this template.

Closes MahApps#3660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@punker76 punker76

Labels
Bug
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@punker76 @VahidHajizadeh