Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New try for LoginDialog Password Preview Feature #1873

Merged
merged 5 commits into from Apr 23, 2015
Merged

New try for LoginDialog Password Preview Feature #1873

merged 5 commits into from Apr 23, 2015

Conversation

bitbeans
Copy link
Contributor

Fixes #1546.

<Border x:Name="PasswordRevealIconEyeBorder" Background="Transparent" Margin="1,1,3,1" BorderThickness="{TemplateBinding BorderThickness}">
<Rectangle Width="20" Height="15" x:Name="IconEye" VerticalAlignment="Center" Margin="3,0" HorizontalAlignment="Center" Fill="{Binding Path=Foreground, RelativeSource={RelativeSource FindAncestor, AncestorType={x:Type Button}}}">
<Rectangle.OpacityMask>
<VisualBrush Stretch="Fill" Visual="{DynamicResource appbar_eye}" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't use icons from MahApps.Metro.Resources here, cause it's not included in MahApps.Metro nuget package, this should be added here.

- Removed the MahApps.Metro.Resources dependency
@punker76 punker76 added this to the 1.2.0 milestone Apr 23, 2015
punker76 added a commit that referenced this pull request Apr 23, 2015
New try for LoginDialog Password Preview Feature
@punker76 punker76 merged commit 5999b37 into MahApps:master Apr 23, 2015
@punker76
Copy link
Member

@bitbeans thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants