Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AssemblyInfo.cs #1985

Merged
merged 2 commits into from Jun 17, 2015
Merged

Update AssemblyInfo.cs #1985

merged 2 commits into from Jun 17, 2015

Conversation

DaCheeseMan
Copy link
Contributor

Added assembly Company Info:
[assembly: AssemblyCompany("MahApps Metro")]

Added assembly Company Info:
[assembly: AssemblyCompany("MahApps Metro")]
@@ -18,5 +18,5 @@
[assembly: AssemblyTitleAttribute("MahApps.Metro")]
[assembly: AssemblyDescriptionAttribute("Toolkit for creating Metro styled WPF apps")]
[assembly: AssemblyProductAttribute("MahApps.Metro 1.1.3-ALPHA")]

[assembly: AssemblyCompany("MahApps Metro")]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@punker76 I think this could be simplified to MahApps or even MahApps Team - let me know what your thoughts are on this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!MahApps Team sounds good.

/Andreas

On Tue, Jun 16, 2015 at 6:28 AM -0700, "Brendan Forster" notifications@github.com wrote:

In MahApps.Metro/Properties/AssemblyInfo.cs:

@@ -18,5 +18,5 @@
[assembly: AssemblyTitleAttribute("MahApps.Metro")]
[assembly: AssemblyDescriptionAttribute("Toolkit for creating Metro styled WPF apps")]

[assembly: AssemblyProductAttribute("MahApps.Metro 1.1.3-ALPHA")]

+[assembly: AssemblyCompany("MahApps Metro")]

@punker76 I think this could be simplified to MahApps or even MahApps Team - let me know what your thoughts are on this.


Reply to this email directly or view it on GitHub.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shiftkey MahApps sounds good, cause https://github.com/MahApps
/cc @DaCheeseMan

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just MahApps sounds good!

@Jyrka98
Copy link

Jyrka98 commented Jun 16, 2015

maybe add this too?:
[assembly: XmlnsPrefix("http://metro.mahapps.com/winfx/xaml/shared", "mahapps")]
[assembly: XmlnsPrefix("http://metro.mahapps.com/winfx/xaml/controls", "mahapps")]

@punker76
Copy link
Member

@Jyrka98 why?

@Jyrka98
Copy link

Jyrka98 commented Jun 16, 2015

@punker76 why not? :P
this doesn't force the use of it. it's just the default that vs will suggest

@shiftkey
Copy link

@Jyrka98 @punker76 let's discuss this change elsewhere. This PR was raised as the lack of a Company attribute was causing certification of an application to fail.

@punker76
Copy link
Member

@shiftkey yepp, I share your opinion, so @DaCheeseMan can you update this PR? thx

@DaCheeseMan
Copy link
Contributor Author

Done? i updated the Company name to only "MahApps".

punker76 added a commit that referenced this pull request Jun 17, 2015
@punker76 punker76 merged commit 5ed3f76 into MahApps:master Jun 17, 2015
@punker76
Copy link
Member

@DaCheeseMan yepp, thx

@DaCheeseMan DaCheeseMan deleted the patch-1 branch June 17, 2015 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants