Dynamic theme for window commands, code cleanup... #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nikolovjovan
commented
Oct 4, 2015
nikolovjovan
commented
- Extracted WindowButtonCommands.xaml and WindowCommands.xaml out of MetroWindow.xaml. Same has been done with the clean style.
- Added TitleAlignment DependencyProperty to MetroWindow. CleanWindow now uses this property for the centered title.
- Added ShowLastSeparator and SeparatorHeight properties to WindowCommands. New way of handling items in WindowCommands had to be implemented for the ShowLastSeparator property.
- Marked WindowMinButtonStyle, WindowMaxButtonStyle and WindowCloseButtonStyle as obsolete. Everything that used these properties has been changed and is now using the new properties from WindowButtonCommands class.
- Dynamic theme support for both WindowCommands and WindowButtonCommands. The styles of the buttons now change based on the foreground brush. Issue Nasty bug when using OverrideDefaultWindowCommandsBrush #2086 is now fixed.
- Extracted WindowButtonCommands.xaml and WindowCommands.xaml out of MetroWindow.xaml. Same has been done with the clean style. - Added TitleAlignment DependencyProperty to MetroWindow. CleanWindow now uses this property for the centered title. - Added ShowLastSeparator and SeparatorHeight properties to WindowCommands. New way of handling items in WindowCommands had to be implemented for the ShowLastSeparator property. - Marked WindowMinButtonStyle, WindowMaxButtonStyle and WindowCloseButtonStyle as obsolete. Everything that used these properties has been changed and is now using the new properties from WindowButtonCommands class. - Dynamic theme support for both WindowCommands and WindowButtonCommands. The styles of the buttons now change based on the foreground brush. Issue #2086 is now fixed.
punker76
added a commit
that referenced
this pull request
Oct 5, 2015
Dynamic theme for window commands, code cleanup...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.