Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringToVisibilityConverter should handle null like an empty string #2793

Merged
merged 1 commit into from
Jan 5, 2017
Merged

StringToVisibilityConverter should handle null like an empty string #2793

merged 1 commit into from
Jan 5, 2017

Conversation

thoemmi
Copy link
Collaborator

@thoemmi thoemmi commented Jan 4, 2017

What changed?

Currently StringToVisibilityConverter does not handle null gracefully. If the value is null, the output is null too. IMHO null should be handled like an empty string, i.e. if the value is null, the output should be FalseEquivalent (or Visibility.Visible, if OppositeStringValue is true)

@punker76 punker76 added this to the 1.4.1 milestone Jan 5, 2017
@thoemmi thoemmi requested a review from punker76 January 5, 2017 20:00
punker76
punker76 approved these changes Jan 5, 2017
View reviewed changes
Copy link
Member

@punker76 punker76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thoemmi makes sense 👍

@punker76 punker76 merged commit 072a138 into develop Jan 5, 2017
@thoemmi thoemmi deleted the improved-StringToVisibilityConverter branch January 5, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@punker76 punker76 punker76 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
1.4.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thoemmi @punker76