New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringToVisibilityConverter should handle null like an empty string #2793

Merged
merged 1 commit into from Jan 5, 2017

Conversation

Projects
None yet
2 participants
@thoemmi
Collaborator

thoemmi commented Jan 4, 2017

What changed?

Currently StringToVisibilityConverter does not handle null gracefully. If the value is null, the output is null too. IMHO null should be handled like an empty string, i.e. if the value is null, the output should be FalseEquivalent (or Visibility.Visible, if OppositeStringValue is true)

@punker76 punker76 added this to the 1.4.1 milestone Jan 5, 2017

@thoemmi thoemmi requested a review from punker76 Jan 5, 2017

@punker76

@thoemmi makes sense 👍

@punker76 punker76 merged commit 072a138 into develop Jan 5, 2017

1 check passed

continuous-integration/teamcity Finished TeamCity Build MahApps.Metro PullRequest :: MahApps.Metro PullRequests : Tests passed: 62
Details

@thoemmi thoemmi deleted the improved-StringToVisibilityConverter branch Jan 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment