Toolbar support #330
Merged
Toolbar support #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It wasn't an issue with the screenshots, but with some of the commits in the previous pull request. No longer an issue. |
|
Looks good from here. Will test it out tonight and confirm. |
|
Did you get a chance to look at this? Any suggestions? |
|
Haven't had a chance I'm afraid. Aiming for the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toolbar support - take 2
Comments from:
flagbug - That diff doesn't look very clean...
shiftkey - I think your line endings are off - that's generally the root cause of what you're seeing.
Not sure what you are talking about - can you mark it in the image?