Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotnet core 3.0 support #3370

Merged
merged 12 commits into from Nov 17, 2018
Merged

Add dotnet core 3.0 support #3370

merged 12 commits into from Nov 17, 2018

Conversation

punker76
Copy link
Member

@punker76 punker76 commented Nov 14, 2018

Describe the changes you have made to improve this project

Support DotNet Core 3.0

  • Add target netcoreapp3.0 and use FrameworkReference Microsoft.DesktopUI for this
  • Disable paket (doesn't support netcoreapp3.0) and use package references
  • Change the SDK from MSBuild.Sdk.Extras to Microsoft.NET.Sdk.Wpf
  • Remove the sdk from global.json (so it takes the latest)
  • Add installing the SDK to appveyor.yml
  • Run all other targets (net45, net46, net47)

@punker76 punker76 added this to the 2.0.0 milestone Nov 14, 2018
@Lakritzator
Copy link

It's nice to see you already took the initiative, I unfortunately didn't have time yet.
Don't forget to replace build.ps1, your version is deeply integrated with paket.

If you need help, let me know!!!!!

P.S.
One thing I do need to mention, currently the dotnet core 3.0 SDK can some times be unstable!!
Using the latest might break your build...

@punker76 punker76 changed the title WIP Add dotnet core 3.0 support Add dotnet core 3.0 support Nov 17, 2018
@punker76 punker76 merged commit 99ed4f2 into develop Nov 17, 2018
@punker76 punker76 deleted the feature/dotNetCore30 branch November 17, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants