Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Control Underline Position #3524

Merged
merged 23 commits into from Jun 8, 2019

Conversation

Evangelink
Copy link
Contributor

@Evangelink Evangelink commented Jun 6, 2019

Describe the changes you have made to improve this project

A dependency property UnderlinePlacement was added to the TabControlHelper class that allows a person to set the underline position in the various tab controls. The property is a Dock type and can be set to Null (default), Left, Right, Top or Bottom respectively.

Additional context

See #3048
I have tried to follow this tutorial to get my change onto @jammerxd PR but couldn't manage to do so. Feel free to just cherry-pick the commit(s) and push them back to the original PR.

Closes #3048

@Evangelink
Copy link
Contributor Author

FYI the 2 problems found by Codacy are FPs (the methods can't be made static as they are interface implementations).

@punker76 punker76 added this to the 2.0.0 milestone Jun 7, 2019
Fix all TabControl styles to use the Underlined TabPanel again.
Remove the PlacementToOppositePlacementConverter and change the UnderlinePlacement type to allow nullable Dock value. With these changes we don't need the PlacementToOppositePlacementConverter and get the old default behavior back.
Add a ComboBox to set the new UnderlinePlacement property.
@punker76 punker76 merged commit aa8a9bf into MahApps:develop Jun 8, 2019
@punker76
Copy link
Member

punker76 commented Jun 8, 2019

@jammerxd @Evangelink your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants