NumericUpDown: Add a property to control changing value with key Enter #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new dependency property UpDownButtonsFocusable to allow changing the Focusable property of the up and down buttons. The default is true to keep the current behavior. If the up or down button will be used then the focus will move to it and triggers the lost focus event of the inner TextBox to change the value.
Add new dependency property ChangeValueOnTextChanged which indicates whether the value will be changed directly on every TextBox text changed event or when using the Enter key.
|
@wunianqing your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made to improve this project
This PR was create after discussing with @wunianqing (#3522): The
NumericUpDowncontrol will response on every enter and change their value. This will cause a strange behavior when you binding value to a control like Slider. So I added a property to allow value effect after press enter.ChangeValueOnTextChangedto enable changing value from manually user input. This property indicates whether the value will be changed directly on every TextBox text changed event or when using the Enter key.UpDownButtonsFocusableto allow changing the Focusable property of the up and down buttons.The default is true to keep the current behavior. If the up or down button will be used then the focus will move to it and triggers the lost focus event of the inner TextBox to change the value.
Additional context
Add any other context or screenshots about the feature request here.
Closed Issues