Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delegate to customize external dialog window #3550

Merged
merged 2 commits into from Jul 15, 2019
Merged

Add delegate to customize external dialog window #3550

merged 2 commits into from Jul 15, 2019

Conversation

RayMMond
Copy link

@RayMMond RayMMond commented Jul 15, 2019 •
edited by punker76

Describe the changes you have made to improve this project

  1. Add delegate to customize external dialog window.
  2. Remove dialog button's height restriction, using MinHeight instead of Height.

Unit test

I really don't know, sorry. Maybe some guidance?

Additional context

None.

Closed Issues

None.

Add delegate to costomize external dialog window.
8c963ec 
Openup dialog button's height, using MinHeight instead of Height.
@RayMMond
Copy link
Author

Do I need to fix this Quality Review issue?

@punker76 punker76 changed the title Open up dialog settings Add delegate to customize external dialog window Jul 15, 2019
@punker76 punker76 added this to the 2.0.0 milestone Jul 15, 2019
@punker76 punker76 merged commit 47c7d81 into MahApps:develop Jul 15, 2019
@punker76
Copy link
Member

@RayMMond your changes have been merged, thanks for your contribution 👍

@RayMMond RayMMond deleted the OpenupDialogSettings branch July 17, 2019 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RayMMond @punker76