Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HamburgerMenu: Allow using own items together with the new HamburgerMenuItemStyleSelector #3619

Merged
merged 1 commit into from Oct 1, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -7,7 +7,7 @@ namespace MahApps.Metro.Controls
/// <summary>
/// The HamburgerMenuItem provides an implementation for HamburgerMenu entries.
/// </summary>
public class HamburgerMenuItem : HamburgerMenuItemBase, ICommandSource
public class HamburgerMenuItem : HamburgerMenuItemBase, IHamburgerMenuItem, ICommandSource
{
/// <summary>
/// Identifies the <see cref="Label"/> dependency property.
Expand Down
Expand Up @@ -19,14 +19,14 @@ public override Style SelectStyle(object item, DependencyObject container)
var hamburgerMenu = listBox?.TryFindParent<HamburgerMenu>();
if (hamburgerMenu != null)
{
if (item is HamburgerMenuSeparatorItem)
if (item is IHamburgerMenuSeparatorItem)
{
if (hamburgerMenu.SeparatorItemContainerStyle != null)
{
return hamburgerMenu.SeparatorItemContainerStyle;
}
}
else if (item is HamburgerMenuItem)
else
{
var itemContainerStyle = this.IsItemOptions ? hamburgerMenu.OptionsItemContainerStyle : hamburgerMenu.ItemContainerStyle;
if (itemContainerStyle != null)
Expand Down
Expand Up @@ -5,7 +5,7 @@ namespace MahApps.Metro.Controls
/// <summary>
/// The HamburgerMenuSeparatorItem provides an separator based implementation for HamburgerMenu entries.
/// </summary>
public class HamburgerMenuSeparatorItem : HamburgerMenuItemBase
public class HamburgerMenuSeparatorItem : HamburgerMenuItemBase, IHamburgerMenuSeparatorItem
{
protected override Freezable CreateInstanceCore()
{
Expand Down
@@ -0,0 +1,13 @@
namespace MahApps.Metro.Controls
{
public interface IHamburgerMenuItem
{
/// <summary>
/// Gets or sets a value indicating whether this item is enabled in the user interface (UI).
/// </summary>
/// <returns>
/// true if the item is enabled; otherwise, false. The default value is true.
/// </returns>
bool IsEnabled { get; set; }
}
}
@@ -0,0 +1,6 @@
namespace MahApps.Metro.Controls
{
public interface IHamburgerMenuSeparatorItem
{
}
}