Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GroupBoxHelper to HeaderedControlHelper and introduced a new AttachedProperty HeaderBackground #3636

Merged
merged 1 commit into from Oct 7, 2019

Conversation

timunie
Copy link
Collaborator

@timunie timunie commented Oct 7, 2019

Describe the changes you have made to improve this project

  • GroupBoxHelper was renamed to HeaderedControlHelper as it applies to all HeaderControls.
  • Added a new AttachedProperty to set the Background of the header part: HeaderedControlHelper.HeaderBackground. That way one can define a Background of the Content and of the Header seperatly.

/!\ This is a Breaking Change

Unit test
None

Additional context
Here is a result how it might look (The default style did not change)
image

Closed Issues
Closes #3634
Closes #3633

@punker76 punker76 added this to the 2.0.0 milestone Oct 7, 2019
…ew attached property for header background

- Rename GroupBoxHelper to HeaderedControlHelper
- Added attached property HeaderBackground
@punker76 punker76 merged commit 15ef18f into MahApps:develop Oct 7, 2019
@punker76
Copy link
Member

punker76 commented Oct 7, 2019

@timunie your #Hacktoberfest changes have been merged, thanks for your contribution 👍

@timunie timunie deleted the RenameGroupBoxHelper branch October 9, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants