Fix issue with P, % and ‰ used in StringFormat outside of the format item #3645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgnslndh
changed the title
punker76
force-pushed
the
feature/numericupdown-percentage
branch
from
9e9a784
to
9ee4aea
Compare
- Define the locale to be used in this string operation. - Make 'TryFormatHexadecimal' a static method.
- Remove this commented out code. - Correct this '|' to '||'. - Add a 'default' clause to this 'switch' statement. - Remove the unused private method 'OnHasDecimalsChanged'. - Make 'TryGetNumberFromText' a static method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with P, % and ‰ used in the StringFormat property of NumericUpDown but outside of the format item. "{}{0:P}" would work but "{}{0:0.0} P" would not work correctly.
Unit test
Added additional asserts in appropriate unit tests.
Related Issues
This PR fixes a couple of problems mentioned in #3376 but does not resolve the issue completely. It only deals with using special characters outside of the format item. Other concerns in the issue is left unresolved.