Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish explicit WindowCommand controls styles #3689

Merged
merged 7 commits into from Nov 13, 2019
Merged

Publish explicit WindowCommand controls styles #3689

merged 7 commits into from Nov 13, 2019

Conversation

punker76
Copy link
Member

@punker76 punker76 commented Nov 13, 2019 •
edited

Describe the changes you have made to improve this project

  • Add WindowCommand styles to Controls RD
    • MahApps.Styles.Control.WindowCommands
    • MahApps.Styles.Button.WindowCommands
    • MahApps.Styles.ToggleButton.WindowCommands
    • MahApps.Styles.SplitButton.WindowCommands
    • MahApps.Styles.SplitButton.Button.WindowCommands
    • MahApps.Styles.SplitButton.ButtonArrow.WindowCommands
    • MahApps.Styles.DropDownButton.WindowCommands
    • MahApps.Styles.DropDownButton.Button.WindowCommands
    • MahApps.Templates.Button.WindowCommands
    • MahApps.Templates.ToggleButton.WindowCommands
    • MahApps.Styles.ToggleButton.ToolBarOverflow
    • MahApps.Styles.WindowCommandsItem
    • MahApps.Styles.WindowCommands.Base
    • MahApps.Styles.WindowCommands
  • Fix TemplatePart at MetroWindow for WindowCommands/WindowButtonCommands
  • Fix possible System.Windows.Data error for ControlsHelper.ContentCharacterCasing
System.Windows.Data Error: 4 : Cannot find source for binding with reference 'RelativeSource FindAncestor, AncestorType='MahApps.Metro.Controls.WindowCommands', AncestorLevel='1''. BindingExpression:Path=(0); DataItem=null; target element is 'ContentControlEx' (Name='PART_ContentControlEx'); target property is 'ContentCharacterCasing' (type 'CharacterCasing')
  • Remove unnecessary light and dark WindowCommands templates
    • Remove MahApps.Templates.WindowCommands.Light
    • Remove MahApps.Templates.WindowCommands.Dark
    • Add MahApps.Templates.WindowCommands

Relates to #3681

@punker76
(GH-3681) Add WindowCommands styles to Controls RD
e32d8ac
@punker76
(GH-3681) Fix TemplatePart at MetroWindow for WindowCommands/WindowBu…
a4f1133 
…ttonCommands
@punker76
(GH-3681) Fix possible System.Windows.Data error for ControlsHelper.C…
09869eb 
…ontentCharacterCasing

System.Windows.Data Error: 4 : Cannot find source for binding with reference 'RelativeSource FindAncestor, AncestorType='MahApps.Metro.Controls.WindowCommands', AncestorLevel='1''. BindingExpression:Path=(0); DataItem=null; target element is 'ContentControlEx' (Name='PART_ContentControlEx'); target property is 'ContentCharacterCasing' (type 'CharacterCasing')
@punker76
(maint) ReSharper Suppress Message EmptyConstructor
a2887d8
@punker76 punker76 added this to the 2.0.0 milestone Nov 13, 2019
@punker76
(GH-3681) Remove unnecessary light and dark WindowCommands templates
e7a1b29 
- Remove `MahApps.Templates.WindowCommands.Light`
- Remove `MahApps.Templates.WindowCommands.Dark`
- Add `MahApps.Templates.WindowCommands`
@punker76
(maint) Move WindowCommandsItem to own file, format WindowCommands
147f968
@punker76
(maint) Reduce LINQ usage
b84789e
@punker76 punker76 merged commit 1d96855 into develop Nov 13, 2019
@punker76 punker76 deleted the WindowCommands_Styles_Fix branch November 13, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Breaking Change
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@punker76