New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching to ThemeManager from ControlzEx #3771
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@timunie FYI |
punker76
force-pushed
the
feature/ThemeManager
branch
from
April 15, 2020 19:49
a18cbf4
to
6e115b7
Compare
punker76
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@batzen LGTM!
@batzen thx mate |
I can't seem to find any documentation for the transition from ThemeManager to ControlzEx. I used MahApps.Metro.ThemeManager.AddAccent in my project. How do I do the same thing now since ThemeManager in MahApps.Metro has been removed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the ThemeManager and switches everything to the general purpose ThemeManager from ControlzEx.
This allows seamless sync of themes across different libraries, for example MahApps.Metro and Fluent.Ribbon.
This "new" ThemeManager also contains the ability to generate themes at runtime while taking the current windows settings into account and allowing users to choose to use HSL colors for accents etc.. HSL colors don't use the alpha channel for the accent color steps, but tinted colors instead.