Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to ThemeManager from ControlzEx #3771

Merged
merged 15 commits into from Apr 15, 2020

Conversation

batzen
Copy link
Collaborator

@batzen batzen commented Apr 6, 2020

This PR removes the ThemeManager and switches everything to the general purpose ThemeManager from ControlzEx.
This allows seamless sync of themes across different libraries, for example MahApps.Metro and Fluent.Ribbon.
This "new" ThemeManager also contains the ability to generate themes at runtime while taking the current windows settings into account and allowing users to choose to use HSL colors for accents etc.. HSL colors don't use the alpha channel for the accent color steps, but tinted colors instead.

@batzen batzen requested a review from punker76 April 6, 2020 19:29
@batzen
Copy link
Collaborator Author

batzen commented Apr 6, 2020

@timunie FYI

@batzen batzen added this to the 2.0.0 milestone Apr 6, 2020
@punker76 punker76 removed the Feature label Apr 15, 2020
Copy link
Member

@punker76 punker76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@batzen LGTM!

@punker76 punker76 merged commit 443389c into MahApps:develop Apr 15, 2020
@punker76
Copy link
Member

@batzen thx mate

@tokm
Copy link

tokm commented May 27, 2020

I can't seem to find any documentation for the transition from ThemeManager to ControlzEx. I used MahApps.Metro.ThemeManager.AddAccent in my project. How do I do the same thing now since ThemeManager in MahApps.Metro has been removed?

@timunie
Copy link
Collaborator

timunie commented May 28, 2020

@tokm see: MahApps/mahapps.com#8

@batzen batzen deleted the feature/ThemeManager branch December 17, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants