Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IsVisible property to HambugerMenuItemBase #3782

Merged
merged 2 commits into from Apr 28, 2020

Conversation

bNobo
Copy link

@bNobo bNobo commented Apr 26, 2020

I've added a Visibility property to HamburgerMenuItem and HamburgerMenuSeparatorItem in response to issue #3768

Closed Issues
It will closes #3768

@timunie
Copy link
Collaborator

timunie commented Apr 27, 2020

Hi @bNobo ,

is there a reason you did not implement this in the base class? I am sorry if you got me wrong, I wanted to confirm your first idea.

@bNobo
Copy link
Author

bNobo commented Apr 27, 2020

Hi @timunie ,

you're absolutely right, I'll move the property to the base class to avoid duplication. I've also realized I forgot to update the template of other HamburgerMenuItemBase descendants like HamburgerMenuHeaderItem. I will fix that too.

@bNobo
Copy link
Author

bNobo commented Apr 27, 2020

Everything should be OK now, Visibility property works for every HamburgerMenuItemBase descendants. Feel free to make me know if I still can improve the code in any way.

@punker76 punker76 force-pushed the feature/HamburgerMenu_Item_Visibility branch from 2177c13 to 213117d Compare April 28, 2020 20:54
IMO IsVisible is the better way to say if an item should be shown or not. With the Visibility property you can set an item also to hide which means that the item is only hidden.
@punker76 punker76 changed the title [RFC] add Visibility property to HambugerMenu item and separator item Add IsVisible property to HambugerMenuItemBase Apr 28, 2020
@punker76
Copy link
Member

@bNobo your changes have been merged, thanks for your contribution 👍

I've changed the property from Visibility to IsVisible. IMO IsVisible is the better way to say if an item should be shown or not. With the Visibility property you can set an item also to hide which means that the item is only hidden.

@punker76 punker76 added this to the 2.0.0 milestone Apr 28, 2020
@punker76 punker76 merged commit 5873948 into MahApps:develop Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Toggling visibility on hamburger menu
3 participants