Resizeable SplitViewPane #3793
Merged
Resizeable SplitViewPane #3793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a Preview:
|
punker76
requested changes
May 9, 2020
There was a problem hiding this comment.
Please look at the missing properties at HamburgerMenu.
I also got this while I'm dragging
System.Windows.Data Error: 8 : Cannot save value from target back to source. BindingExpression:Path=OpenPaneLength; DataItem='HamburgerMenu' (Name='HamburgerMenuControl'); target element is 'SplitView' (Name='MainSplitView'); target property is 'OpenPaneLength' (type 'Double') ArgumentException:'System.ArgumentException: '-503' is not a valid value for the 'System.Windows.FrameworkElement.Width' property on a Setter.
at System.Windows.Setter.Seal()
at System.Windows.SetterBaseCollection.Seal()
at System.Windows.Style.Seal()
at MahApps.Metro.Controls.HamburgerMenu.ChangeItemFocusVisualStyle() in d:\projects\git\MahApps.Metro\src\MahApps.Metro\Controls\HamburgerMenu\HamburgerMenu.Properties.cs:line 463
at MahApps.Metro.Controls.HamburgerMenu.OpenPaneLengthPropertyChangedCallback(DependencyObject dependencyObject, DependencyPropertyChangedEventArgs args) in d:\projects\git\MahApps.Metro\src\MahApps.Metro\Controls\HamburgerMenu\HamburgerMenu.Properties.cs:line 26
at System.Windows.DependencyObject.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
at System.Windows.FrameworkElement.OnPropertyChanged(DependencyPropertyChangedEventArgs e)
at System.Windows.DependencyObject.NotifyPropertyChange(DependencyPropertyChangedEventArgs args)
at System.Windows.DependencyObject.UpdateEffectiveValue(EntryIndex entryIndex, DependencyProperty dp, PropertyMetadata metadata, EffectiveValueEntry oldEntry, EffectiveValueEntry& newEntry, Boolean coerceWithDeferredReference, Boolean coerceWithCurrentValue, OperationType operationType)
at System.Windows.DependencyObject.SetValueCommon(DependencyProperty dp, Object value, PropertyMetadata metadata, Boolean coerceWithDeferredReference, Boolean coerceWithCurrentValue, OperationType operationType, Boolean isInternal)
at MS.Internal.Data.PropertyPathWorker.SetValue(Object item, Object value)
at System.Windows.Data.BindingExpression.UpdateSource(Object value)'
I don't get this error anymore. But you should double check anyway 😄 Have a great weekend |
punker76
force-pushed
the
SplitViewResizeable
branch
from
b29169e
to
8fbcbc3
Compare
- First steps
…ximumOpenPaneLength didn't work.
…ggleSwitches to Demo
punker76
force-pushed
the
SplitViewResizeable
branch
from
99d7eff
to
9217584
Compare
…ulate the correct value
…gth to calculate the correct value
punker76
approved these changes
May 12, 2020
|
@timunie your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made to improve this project
Stylefor theThumbboolto indicate if Pane is ResizeableMinimumOpenPaneLengthandMaximumOpenPaneLengthClosed Issues
Closes #3763