Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Validation Tooltip that never shows up. #3804

Merged
merged 1 commit into from May 22, 2020

Conversation

luisfb
Copy link
Contributor

@luisfb luisfb commented May 21, 2020

I was having an issue where the canShow variable always ends up false.
This change should fix the problem and not interfere in the current logical flow.

@punker76
Copy link
Member

@luisfb Do you have an example for this?

@luisfb
Copy link
Contributor Author

luisfb commented May 22, 2020

Yes. I recorded a video.
First take a look at my ViewModelBase and also the code that adds the error:
ViewModel Base
Error Command

Here is the video of the NOT Working pop-up error:

Not Working video

After my change (this pull request), here is the result:

Working video

I was having an issue where the canShow variable always ends up false.
This change should fix the problem and not interfere in the current logical flow.
@punker76 punker76 added this to the 2.0.0 milestone May 22, 2020
@punker76 punker76 merged commit 5d41332 into MahApps:develop May 22, 2020
@punker76
Copy link
Member

@luisfb your changes have been merged, thanks for your contribution 👍 Thx for using the latest alpha hot stuff and reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants