(GH-3829) Fix DateTimePicker BindingExpression errors #3830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use a DatePickerTextBox inside the TimePickerBase which causes these errors with TargetFramework 4.8 and higher. The DatePickerTextBox style uses triggers for UseNetFx472CompatibleAccessibilityFeatures, but the Bindings are looking for a DatePicker. To fix this we added a new style for our DatePickerTextBox called MahApps.Styles.DatePickerTextBox.TimePickerBase.
punker76
deleted the
fix/GH-3829-DatePicker-UseNetFx472CompatibleAccessibilityFeatures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made to improve this project
We use a DatePickerTextBox inside the TimePickerBase which causes these errors with TargetFramework 4.8 and higher.
The DatePickerTextBox style uses triggers for UseNetFx472CompatibleAccessibilityFeatures, but the Bindings are looking for a DatePicker, that's why we get these errors.
To fix this we added a new style for our DatePickerTextBox called
MahApps.Styles.DatePickerTextBox.TimePickerBase.Closed Issues
Closes #3829