Add option to close ColorPicker on selected color changed #4129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FroggieFrog your changes have been merged, thanks for your contribution 👍 |
|
Hi @FroggieFrog I really like your idea of having the autoclose option. It didn't came into my mind when I wrote this control because I needed it to stay open as the update would take a few seconds. 👍🏻 I would like to ask if you can extend the new DP also in the docs? I want the docs to be up to date 😉 May thanks, happy coding and a great weekend |
|
The PR for the doc is here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made to improve this project
This PR adds a property
CloseOnSelectedColorChangedto theColorPickercontrol which allows the user to specify if the DropDown should be closed after a color is selected from a palette.Further info can be found in #4128.
Unit test
None, because I don't know how to to that for this control.
Additional context
The default value is
falseto not break existing behavior.Closed Issues
Closes #4128