Add an option to always show ErrorTemplate text #4451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…late, regardless of focus or mouse over.
|
Apologies for the delay; holidays prevented me getting confirmation @dotnet-policy-service agree company="Aristocrat Technologies" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to always show ErrorTemplate text, regardless of focus or mouse over.
This change extends the Validation Error Template text show options to include an 'always show' option.
The existing options of showing on focus or on mouseover did not work well for me when trying to apply the error template to a border surrounding a group of radio buttons used primarily on a touch interface. Mouseover isn't a thing on touch, and focus meant the text would only show when a radio button was selected, which removed the error entirely.
This change introduces a new attached property in ValidationHelper to enable the behavior and a new style trigger that will enable when the template has errors and the new attached property, ValidationHelper.AlwaysShowValidationError, is set to true for the element.
Unit test
I did not find existing unit testing of the ValidationHelper properties to model any new test after.