Changed Math.Random with crypto.randomInt

Maheshkumar-Kakade · Oct 17, 2021 · b27de1c · b27de1c
1 parent d4a4f5b
commit b27de1c
Show file tree

Hide file tree

Showing 4 changed files with 564 additions and 503 deletions.
diff --git a/README.md b/README.md
@@ -24,7 +24,7 @@ npm install otp-generator --save
 ## Usage
 
 ```js
-var otpGenerator = require('otp-generator')
+const otpGenerator = require('otp-generator')
 
 otpGenerator.generate(6, { upperCase: false, specialChars: false });
 

diff --git a/index.js b/index.js
@@ -1,16 +1,13 @@
 /**
  * Generate password from allowed word
  */
+const crypto = require('crypto')
+
 const digits = '0123456789'
 const alphabets = 'abcdefghijklmnopqrstuvwxyz'
 const upperCase = alphabets.toUpperCase()
 const specialChars = '#!&@'
 
-function rand (min, max) {
-  const random = Math.random()
-  return Math.floor(random * (max - min) + min)
-}
-
 module.exports = {
   /**
    * Generate OTP of the length
@@ -36,7 +33,7 @@ module.exports = {
       ((generateOptions.specialChars || '') && specialChars)
     let password = ''
     while (password.length < length) {
-      const charIndex = rand(0, allowsChars.length - 1)
+      const charIndex = crypto.randomInt(0, allowsChars.length)
       password += allowsChars[charIndex]
     }
     return password