feat: add setting for numerical base of addresses #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, the settings option is definitely reasonable - I mentioned it as a "lazy" option in the issue (#160), but the only real downside is that it doesn't make the display and its configuration completely decoupled from the rest of the program and other displays. Maybe in this case you don't care if it's not decoupled? I think you also need to update the width calculation for the address header for the different bases at https://github.com/Mahlet-Inc/hobbits/blob/master/src/hobbits-plugins/displays/Hex/hex.cpp#LL146C19-L146C19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #160
So, this does it for the hex display... but two things I'd like feedback on. First, I should probably use a dropdown instead of a spinbox because nobody wants base 15. Also, now that I'm using this more (great software, btw!), I noticed that most of the other display plugins have the same setting. So would you be alright with me putting this in the settings dialog, rather than in each area separately?