Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add setting for numerical base of addresses #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hut8
Copy link

@hut8 hut8 commented May 22, 2023

Resolves #160

So, this does it for the hex display... but two things I'd like feedback on. First, I should probably use a dropdown instead of a spinbox because nobody wants base 15. Also, now that I'm using this more (great software, btw!), I noticed that most of the other display plugins have the same setting. So would you be alright with me putting this in the settings dialog, rather than in each area separately?

@hello-adam
Copy link
Member

Yeah, the settings option is definitely reasonable - I mentioned it as a "lazy" option in the issue (#160), but the only real downside is that it doesn't make the display and its configuration completely decoupled from the rest of the program and other displays. Maybe in this case you don't care if it's not decoupled?

I think you also need to update the width calculation for the address header for the different bases at https://github.com/Mahlet-Inc/hobbits/blob/master/src/hobbits-plugins/displays/Hex/hex.cpp#LL146C19-L146C19

@hut8 hut8 force-pushed the hut8/adjustable-address-display-base branch from ed28c4d to e77ae99 Compare October 15, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to display offsets in hex
2 participants