Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use json5kit to parse rules and configs #2

Merged
merged 7 commits into from
Apr 22, 2023
Merged

Use json5kit to parse rules and configs #2

merged 7 commits into from
Apr 22, 2023

Conversation

tusharsadhwani
Copy link
Contributor

Resolves #1

@tusharsadhwani
Copy link
Contributor Author

@Mahyar24 can you test once if this works? The package doesn't seem to have tests for me to verify.

@tusharsadhwani
Copy link
Contributor Author

tusharsadhwani commented Apr 22, 2023

If needed I can extract the 3 lines into a separate function to avoid repetition.

@Mahyar24
Copy link
Owner

Mahyar24 commented Apr 22, 2023

Hi, it would be better if you committed to the dev branch. As you suggested, a small function could be a better way too.

@tusharsadhwani tusharsadhwani changed the base branch from master to dev April 22, 2023 12:48
@tusharsadhwani
Copy link
Contributor Author

@Mahyar24 done.

@Mahyar24 Mahyar24 merged commit 1560696 into Mahyar24:dev Apr 22, 2023
@tusharsadhwani tusharsadhwani deleted the patch-1 branch April 22, 2023 13:03
@Mahyar24
Copy link
Owner

It worked. I checked it with JSON5 comments, although io.TextIOWrapper is the correct type.

@tusharsadhwani
Copy link
Contributor Author

Hey! my bad. I meant to use TextIOBase, which is the base class for I believe all file-like objects that output strings.

@Mahyar24
Copy link
Owner

No problem. Thanks for the PR! I'm going to merge it into the master branch, create a release, and use it in production. This will help lots of people in Iran bypass censorship and access the internet. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: use JSON5 for user config
2 participants