-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use json5kit to parse rules and configs #2
Conversation
@Mahyar24 can you test once if this works? The package doesn't seem to have tests for me to verify. |
If needed I can extract the 3 lines into a separate function to avoid repetition. |
Hi, it would be better if you committed to the |
@Mahyar24 done. |
It worked. I checked it with JSON5 comments, although |
Hey! my bad. I meant to use |
No problem. Thanks for the PR! I'm going to merge it into the master branch, create a release, and use it in production. This will help lots of people in Iran bypass censorship and access the internet. :) |
Resolves #1