Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent popups from rendering out of view #1661

Closed
shaman-apprentice opened this issue Jan 12, 2021 · 4 comments
Closed

Prevent popups from rendering out of view #1661

shaman-apprentice opened this issue Jan 12, 2021 · 4 comments
Labels
javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:low Set by PO UX / UI Everything related to design and user experience

Comments

@shaman-apprentice
Copy link
Contributor

Feature request

Description

As a user I want popups to be always completely visible in the view, so that I don't have to shift things around before opening a popup, as shifting things around just for opening a popup is annoying.

Example issues:

  • node context menu and its color-picker are each partially out of view:

    image
  • color-picker and legend are overlapped by ribbon-bar

    image

Acceptance criteria

  • The two examples from above are not reproducable

Assumptions & Exclusions

Development notes (optional Task Breakdown)

  • We could custom implement a solution via getBoundingClientRect (probably a bad idea)
  • We could utilize components like material.angularjs.org
  • We could tackle this issue once after we have moved to Angular. In the long run this is in total probably the least amount of work

Open questions

@shaman-apprentice shaman-apprentice added the UX / UI Everything related to design and user experience label Jan 12, 2021
@BridgeAR BridgeAR added javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:low Set by PO labels Jan 12, 2021
@BridgeAR
Copy link
Member

I am currently cleaning up the backlog. As this does not seem like it's something we are going to address anytime soon, I am going to close it. As soon as we finished the migration, we might pick this up again.

@BridgeAR BridgeAR added the won't implement Won't implement in CC, at least for now label Nov 15, 2021
@shaman-apprentice
Copy link
Contributor Author

I actually planned to tackle it, when migrating context menu and color picker with the help of Angular Materials CDK. Mind if I reopen it?

@BridgeAR BridgeAR reopened this Nov 15, 2021
@BridgeAR BridgeAR removed the won't implement Won't implement in CC, at least for now label Nov 16, 2021
@BridgeAR
Copy link
Member

The need for it is currently pretty low. Please do not invest too much time into it. If it's difficult to resolve, let it be for now.

@shaman-apprentice
Copy link
Contributor Author

FYI: The node context menu has still the problem ;) But I am OK with leaving the issue closed. Then I will ninja fix it when migrating the component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:low Set by PO UX / UI Everything related to design and user experience
Projects
None yet
Development

No branches or pull requests

3 participants