[flutter_appauth] use initWithPresentingWindow to fix deprecation warning #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i browser and can't return back.
|
I've not seen what you mention happen and following is a recording of the example app Screen.Recording.2023-07-15.at.10.58.36.am.movEven so, this change does address a deprecation warning so should be merged in. As the PR title forms part of the commit message when the PR is merged in, are you able to come up with a more descriptive PR title on what this PR addresses? |
MaikuB
changed the title
|
@MaikuB I'm sorry I somehow missed your comment 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[flutter_appauth] fix MacOs auth. Without that it opens regular Safari browser and can't return back.