Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageHandler removed, but not mentioned in changelog #132

Closed
SteveAlexander opened this issue Nov 26, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@SteveAlexander
Copy link

commented Nov 26, 2018

I just upgraded, and MessageHandler is no longer in the codebase.

This is a breaking change, but I don't see a mention of this in the changelog. Looking through commits to see what happened :-)

@SteveAlexander

This comment has been minimized.

Copy link
Author

commented Nov 26, 2018

Found it — it's renamed to SelectNotificationCallback

Maybe add that to the changelog?

@MaikuB

This comment has been minimized.

Copy link
Owner

commented Nov 26, 2018

Will do though curious to know why that broke for you and how you used that before. This was part of renaming the name of the corresponding argument in the initialize method.

@SteveAlexander

This comment has been minimized.

Copy link
Author

commented Nov 26, 2018

Thanks!

So, I wrap the FlutterLocalNotificationsPlugin in order to use it in my app. I do this so that I can initialize it selectively — seeing as on iOS (at least pre 11 I think) initialize causes a "would you give this app permission to notify?" dialog, and I want to control when this request is made.

To enable this, I pass a SelectNotificationCallback into my wrapper when it is created. (It's managed by an InheritedWidget kind of thing, created when my app starts up.) So, I want to have a field that stores this callback. The type of the field was MessageHandler, and it is now SelectNotificationCallback.

Hope that makes sense!

MaikuB added a commit that referenced this issue Dec 1, 2018

@MaikuB MaikuB referenced this issue Dec 1, 2018

Merged

0.4.2+1 release #133

@MaikuB

This comment has been minimized.

Copy link
Owner

commented Dec 1, 2018

Updated the changelog now so closing the issue. Thanks for reporting this

@MaikuB MaikuB closed this Dec 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.