Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_local_notifications] Upgraded Android Gradle Plugin to fix Android build #1781

Merged
merged 7 commits into from Nov 24, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion flutter_local_notifications/android/build.gradle
Expand Up @@ -8,7 +8,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:4.2.2'
classpath 'com.android.tools.build:gradle:7.3.1'
}
}

Expand Down
2 changes: 1 addition & 1 deletion flutter_local_notifications/example/analysis_options.yaml
Expand Up @@ -71,7 +71,7 @@ linter:
- leading_newlines_in_multiline_strings
- library_names
- library_prefixes
- lines_longer_than_80_chars
# - lines_longer_than_80_chars
- list_remove_unrelated_type
- literal_only_boolean_expressions
- missing_whitespace_between_adjacent_strings
Expand Down
10 changes: 5 additions & 5 deletions flutter_local_notifications/example/android/app/build.gradle
Expand Up @@ -56,15 +56,15 @@ android {
}
}

// Temporary workaround as per https://issuetracker.google.com/issues/158060799
Rexios80 marked this conversation as resolved.
Show resolved Hide resolved
lint {
checkReleaseBuilds false
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
}

// Temporary workaround as per https://issuetracker.google.com/issues/158060799
lintOptions {
checkReleaseBuilds false
}
}

flutter {
Expand Down
4 changes: 2 additions & 2 deletions flutter_local_notifications/example/android/build.gradle
@@ -1,12 +1,12 @@
buildscript {
ext.kotlin_version = '1.5.31'
ext.kotlin_version = '1.7.20'
repositories {
google()
mavenCentral()
}

dependencies {
classpath 'com.android.tools.build:gradle:4.2.2'
classpath 'com.android.tools.build:gradle:7.3.1'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}
}
Expand Down
Expand Up @@ -3,4 +3,4 @@ android.useAndroidX=true
android.enableJetifier=true
android.enableR8=true
# https://github.com/robolectric/robolectric/issues/6521
android.jetifier.blacklist=bcprov
android.jetifier.ignorelist=bcprov
@@ -1,6 +1,5 @@
#Sat May 14 14:15:09 AEST 2022
distributionBase=GRADLE_USER_HOME
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-bin.zip
distributionPath=wrapper/dists
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
9 changes: 4 additions & 5 deletions flutter_local_notifications/example/lib/main.dart
@@ -1,15 +1,14 @@
import 'dart:async';
import 'dart:convert';
import 'dart:io';
import 'dart:typed_data';

import 'package:device_info_plus/device_info_plus.dart';
import 'package:flutter/cupertino.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter_local_notifications/flutter_local_notifications.dart';
import 'package:flutter_native_timezone/flutter_native_timezone.dart';
// import 'package:flutter_native_timezone/flutter_native_timezone.dart';
import 'package:http/http.dart' as http;
import 'package:image/image.dart' as image;
import 'package:path_provider/path_provider.dart';
Expand Down Expand Up @@ -209,8 +208,8 @@ Future<void> _configureLocalTimeZone() async {
return;
}
tz.initializeTimeZones();
final String? timeZoneName = await FlutterNativeTimezone.getLocalTimezone();
tz.setLocalLocation(tz.getLocation(timeZoneName!));
// final String? timeZoneName = await FlutterNativeTimezone.getLocalTimezone();
// tz.setLocalLocation(tz.getLocation(timeZoneName!));
}

class PaddedElevatedButton extends StatelessWidget {
Expand Down Expand Up @@ -2392,7 +2391,7 @@ class _HomePageState extends State<HomePage> {
if (Platform.isAndroid) {
final DeviceInfoPlugin deviceInfo = DeviceInfoPlugin();
final AndroidDeviceInfo androidInfo = await deviceInfo.androidInfo;
if (androidInfo.version.sdkInt! < 23) {
if (androidInfo.version.sdkInt < 23) {
return const Text(
'"getActiveNotifications" is available only for Android 6.0 or newer',
);
Expand Down
Expand Up @@ -5,14 +5,12 @@
import FlutterMacOS
import Foundation

import device_info_plus_macos
import device_info_plus
import flutter_local_notifications
import flutter_native_timezone
import path_provider_macos

func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) {
DeviceInfoPlusMacosPlugin.register(with: registry.registrar(forPlugin: "DeviceInfoPlusMacosPlugin"))
FlutterLocalNotificationsPlugin.register(with: registry.registrar(forPlugin: "FlutterLocalNotificationsPlugin"))
FlutterNativeTimezonePlugin.register(with: registry.registrar(forPlugin: "FlutterNativeTimezonePlugin"))
PathProviderPlugin.register(with: registry.registrar(forPlugin: "PathProviderPlugin"))
}
4 changes: 2 additions & 2 deletions flutter_local_notifications/example/pubspec.yaml
Expand Up @@ -4,12 +4,12 @@ publish_to: none

dependencies:
cupertino_icons: ^1.0.2
device_info_plus: ^4.1.3
device_info_plus: ^8.0.0
flutter:
sdk: flutter
flutter_local_notifications:
path: ../
flutter_native_timezone: ^2.0.0
# flutter_native_timezone: ^2.0.0
http: ^0.13.4
image: ^3.0.8
path_provider: ^2.0.0
Expand Down
@@ -1,4 +1,3 @@
import 'dart:typed_data';
import 'package:clock/clock.dart';
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
Expand Down
Expand Up @@ -163,7 +163,6 @@ void main() {
requestAlertPermission: false,
requestBadgePermission: false,
requestSoundPermission: false,
requestCriticalPermission: false,
defaultPresentAlert: false,
defaultPresentBadge: false,
defaultPresentSound: false);
Expand Down
Expand Up @@ -62,7 +62,6 @@ void main() {
requestAlertPermission: false,
requestBadgePermission: false,
requestSoundPermission: false,
requestCriticalPermission: false,
defaultPresentAlert: false,
defaultPresentBadge: false,
defaultPresentSound: false,
Expand Down