WIP sveltekit init #281
Merged
WIP sveltekit init #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove todo from kit mark links as external use absolute links for assets
move site-data to $lib
|
Visit the preview URL for this PR (updated for commit 1941d5f): https://mailcheck-landing--pr281-next-4w7ttv7u.web.app (expires Mon, 02 Aug 2021 11:27:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
update 404 page handling lint some code
imhul
commented
Jun 14, 2021
src/app.scss
Outdated
| @@ -1,5 +1,4 @@ | |||
| @import './styles/normalize'; | |||
| @import './mixins'; | |||
There was a problem hiding this comment.
Подскажи, за что миксины грохнул?)
There was a problem hiding this comment.
они подключены у тебя глобально, зачем их еще раз тянуть?
added 2 commits
June 14, 2021 14:00
nosovk
reviewed
Jun 14, 2021
| @@ -207,9 +207,9 @@ | |||
| </p> | |||
| <div class="emails-block"> | |||
| <div class="main-buttons"> | |||
| <a rel="external" href="https://app.mailcheck.co/" class="btn btn-live-demo" | |||
| <a rel="external" href="https://app.mailcheck.co/" target="_blank" class="btn btn-live-demo" | |||
There was a problem hiding this comment.
ставить тут target=_blanc не нужно, т.к. тут человек идет куда нам нужно - на наш же сайт.
There was a problem hiding this comment.
а external нужно чтобы сказать системе что у нужно отлюкчить урл из обработки роутером
nosovk
reviewed
Jun 15, 2021
| class="affiliate" | ||
| class:intersecting | ||
| use:inview | ||
| on:enter={(event) => { |
There was a problem hiding this comment.
можно обойтись одним handleChange
fix twitter card issue
|
Kudos, SonarCloud Quality Gate passed! |
nosovk
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.