Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade alpine base-image #1039

Closed
wants to merge 1 commit into from
Closed

upgrade alpine base-image #1039

wants to merge 1 commit into from

Conversation

HorayNarea
Copy link
Member

@HorayNarea HorayNarea commented Jun 2, 2019 •
edited
Loading

Upgrades the alpine image from 3.8 to 3.9 on all containers except postgres

Postgres container upgrade would pull in a new major version of postgres which requires some (manual) work the make to old data readable by the new version

Also I changed libressl to openssl because alpine 3.9 has switched back to the OG openssl :D

@HorayNarea HorayNarea requested a review from kaiyou June 2, 2019 22:57
@mergify
Copy link
Contributor

mergify bot commented Jun 2, 2019

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails, read this.

bors bot added a commit that referenced this pull request Jun 2, 2019
@bors
Try #1039:
46cc056
@bors
Copy link
Contributor

bors bot commented Jun 2, 2019

try

Build failed

@blinkeye
Copy link
Contributor

FYI: Alpine 3.10 was released a few days ago: https://alpinelinux.org/posts/Alpine-3.10.0-released.html

@blinkeye
Copy link
Contributor

@HorayNarea : do you intentionally reference a forked MailuStart repo (https://github.com/usrpro/MailuStart.git#egg=mailustart) in the Dockerfiles?

@blinkeye
Copy link
Contributor

@HorayNarea : the update to Alpine:3.9 breaks postfix.

sh: /usr/lib/postfix/post-install: not found
sh: /usr/lib/postfix/master: not found
rsyslogd 8.40.0: running as pid 1, enabling container-specific defaults, press ctl-c to terminate rsyslog
: environment variable TZ is not set, auto correcting this to TZ=UTC [v8.40.0 try https://www.rsyslog.com/e/2442 ]
:  [origin software="rsyslogd" swVersion="8.40.0" x-pid="1" x-info="https://www.rsyslog.com"] start

We also need to change 2 path of files run by the start.py.

I've created a new PR #1050 based on your changes here and rebased against the current master (and solved a conflict).

@HorayNarea
Copy link
Member Author

@HorayNarea : do you intentionally reference a forked MailuStart repo (https://github.com/usrpro/MailuStart.git#egg=mailustart) in the Dockerfiles?

Well yes but actually no. :D
I didn't change which MailuStart is used…

@HorayNarea : the update to Alpine:3.9 breaks postfix.

I… uhh… well… I thought I tested it, but obviously I did it wrong. Maybe shouldn't do important things when I haven't slept enough. 🙃

Since your PR fixes stuff I will close mine. Thanks for cleaning up after me 😘 🗡️

@HorayNarea HorayNarea closed this Jun 23, 2019
@HorayNarea HorayNarea deleted the feat-upgrade-alpine branch June 23, 2019 18:54
@Nebukadneza Nebukadneza mentioned this pull request Jun 23, 2019
Merged
5 tasks
bors bot added a commit that referenced this pull request Jul 23, 2019
@bors @HorayNarea
@Nebukadneza @blinkeye
Merge #1052
2788909 
1052: Upgrade alpine to 3.10 r=mergify[bot] a=Nebukadneza

## What type of PR?
enhancement / bug-fix

## What does this PR do?
Upgrade the alpine base image to 3.10 and clean up ensuing problems. Also directly uses postfix foreground-running with stdout logging.

### Related issue(s)
closes #1049
closes #1051

Note: This is a duplicate effort of #1050 #1039 …

## Prerequistes
- [X] In case of feature or enhancement: documentation updated accordingly
- [X] Unless it's docs or a minor change: add [changelog](https://mailu.io/master/contributors/guide.html#changelog) entry file.

With these images, I have tested manually:
- Email receive to user
  - on main domain
  - on additional domain
  - via an alias on main-domain
  - via an alias on additional domain
  - via catchall
- Email reject
  - of eicar testfiles
- Email sending
- Fetchmail from legacy POP
- Front LE certificates
- Simple overriding for postfix (only postfix.cf), nginx, dovecot, rspamd
- Creating a CalDAV calendar and CardDAV entry using davx5

I have not (yet) tested:
- certdumper
- databases other than sqlite

Todo:
- [x] Get rid of podop at `git+https://github.com/Nebukadneza/Podop.git@fix_py37` once Mailu/Podop#6 is merged
- [x] Bend Mailustart back to original repository
- [x] Test more (? also help wanted ?)

Co-authored-by: Thomas Sänger <thomas@gecko.space>
Co-authored-by: Dario Ernst <dario@kanojo.de>
Co-authored-by: Reto Glauser <git@blinkeye.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyou kaiyou Awaiting requested review from kaiyou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HorayNarea @blinkeye